@dlowan,
Interesting, Deb.
I think I put that relationship down to a "rescue drive", too. Couldn't think of another reason for it, from Milk's point of view. Perhaps the sex was great, but I can only guess about that, going by the storyline.
Oh I thought the murderer was
brilliant as an aggrieved, repressed fellow!... it's just that none of the reasons given: religion, thwarted ambitions, being used & double-crossed by Milk & the mayor, etc, seemed to fully explain why he'd resort to murder. He seemed too much the correct, repressed moralist for that. The murder had a "crime of passion" feel to it, so maybe there
was something in the suggestion of repressed homosexuality? (Sorry, I'm not really certain of what a "reaction formation type" is.)
Actually (without knowing much of Milk's personal history, including the details of his death, prior to seeing the film ) I thought the unstable lover would eventually be his murderer. Unable to cope with sharing his (less than secure) private life with Milk with Milk's public life.