From a groundpounder's perspective, no doubt about it; my favorite General of all time was
Lieutenant General Lewis Burwell "Chesty" Puller
37 years of service, with active duty both enlisted and commissioned, 5 Navy Crosses, The Distinguished Service Cross, Silver Star, 2 Legions of Merit (with Valor Device), Bronze Star (with Valor Device), the Air Medal, the Purple Heart (with clusters), assorted other decorations, and numerous awards and citations granted by Non-US governments and militaries. Among his more memorable quotes are these three, quite illustrative of his spirit and attitude:
"All right, they're on our left, they're on our right, they're in front of us, they're behind us; they can't get away this time."
"We're surrounded. That simplifies our problem."
"We're here to fight."
Chesty lived, ate, slept, and fought, and bled with the troops he led, asking no man to do anything he would not do, and in many cases had done. A hard but just taskmaster, Chesty led by example, earning the respect and admiration of all who served with him. While it has been my privilege to have met him, I never had the honor to be under his command, but my dad did - twice.
Good night, Chesty, where ever you are.