@WBYeats,
jtt's sentence: A number of those men might HAVE MADE excellent citizens if they had not been soured by the recollection of all that they had undergone. But it's too late now as they are all dead.
////////////////
WB wrote: Your sentence would mean they were soured etc, and of course they did not make excellent citizens; but the question is, I just want to express a past possibility; whether it happened, no one knows.
-They might... if they were... (referring to the past)
Possible or impossible?(in any situation/context.)
/////////////////////
A number of those men could have been excellent citizens but we have no way of knowing if that ever happened.
A number of those men might have been excellent citizens but we have no way of knowing if that ever happened.
A number of those men may have been excellent citizens but we have no way of knowing if that ever happened.
A number of those men probably would have been excellent citizens but we have no way of knowing if that ever happened.
A number of those men almost certainly would have been excellent citizens but we have no way of knowing if that ever happened.
A number of those men would have been excellent citizens but we have no way of knowing if that ever happened.
A number of those men definitely would have been excellent citizens but we have no way of knowing if that ever happened.
Many more variations on that theme, WB.